Skip to content

completed the task #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SerhiyShimko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

completed the task #2187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e237d9
completed the task
SerhiyShimko Feb 17, 2026
b06ee8d
edited by Luke
SerhiyShimko Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion src/scripts/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,31 @@
'use strict';

// write your code here
const population = document.querySelectorAll('.population');
const averagePopulation = document.querySelector('.average-population');
const totalPopulation = document.querySelector('.total-population');
const newPopulation = [...document.querySelectorAll('.population')];
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line queries the DOM for the same elements as on line 3. It's more efficient to query the DOM only once and reuse the resulting NodeList. The population variable from line 3 can be used directly in the for...of loop on line 9.

let totalPopulationResult = 0;

for (const onePopulation of newPopulation) {
totalPopulationResult += Number(onePopulation.innerText.split(',').join(''));
}

const newTotalPopulationResult = String(totalPopulationResult).split('');
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic for adding thousands separators is effective, but it's repeated again on lines 23-28. To avoid code duplication, consider creating a reusable function for this task. You could also look into the standard toLocaleString() method, which can format numbers like this in a single line.

const resultTotal = [];

while (newTotalPopulationResult.length) {
resultTotal.unshift(newTotalPopulationResult.splice(-3).join(''));
}

const averagePopulationResult = Math.round(
totalPopulationResult / population.length,
);
const newAveragePopulationResul = String(averagePopulationResult).split('');
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small typo in this variable name. It should probably be newAveragePopulationResult to be consistent.

const resultAverage = [];

while (newAveragePopulationResul.length) {
resultAverage.unshift(newAveragePopulationResul.splice(-3).join(''));
}

totalPopulation.innerText = resultTotal.join(',');
averagePopulation.innerText = resultAverage.join(',');
Loading