solutions by OliverBars · Pull Request #2182 · mate-academy/js_get_data_DOM

OliverBars · 2026-02-13T20:28:38Z

No description provided.

mateacademy-ai-mentor

Review Summary

I am requesting changes because a few checklist-required behaviors are not yet fully met, and they can lead to incorrect results at runtime. Your main logic for selecting .population spans, converting to numbers, and writing total/average (with toLocaleString) looks good, but there are some critical edge cases missing.

Critical issues to fix:

The parsing currently only removes commas; it doesn’t trim or strip other non-digit characters (e.g. non‑breaking spaces or stray text), so Number(text) can still produce NaN and break the calculations [CHECKLIST ITEM #11]. At the point where you read span.innerText (in src/scripts/main.js), normalize the string (e.g. trim(), remove \u00A0, and drop non‑numeric characters) before conversion.
After calling Number(...), you are not checking for invalid values; per the requirements you must validate with Number.isNaN() or Number.isFinite() and either skip invalid entries or handle them explicitly [CHECKLIST ITEMS #11 and #12]. For example, build an array of only valid numeric populations and ignore anything that can’t be converted.
When there are no valid numeric entries (e.g. all invalid or no .population spans), total / populations.length will divide by zero, producing NaN and an incorrect average [CHECKLIST ITEM #3]. Add a guard so that if the filtered array is empty you either set the average to 0 or avoid doing the division.

Minor but recommended improvements:

Before writing results, check that .total-population and .average-population elements exist from document.querySelector to avoid possible runtime errors, and assign the rounded average to a variable before formatting so it’s easy to test.
Once you’ve tightened the parsing, validated numbers, and handled the empty-array case, your solution will fully satisfy the functional requirements; the structure is solid and just needs these robustness fixes.

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2026-02-13T20:31:01Z

src/scripts/main.js

+const populationSpans = document.querySelectorAll('.population');
+
+const populations = Array.from(populationSpans).map((span) => {
+  const text = span.innerText.replace(/,/g, '');


Parsing removes commas but doesn't trim or handle other possible characters (e.g. non-breaking spaces or stray text). Consider trimming and removing non-digit characters before conversion so the value is reliably convertible. This relates to checklist item #11.

mateacademy-ai-mentor · 2026-02-13T20:31:01Z

src/scripts/main.js

+const populations = Array.from(populationSpans).map((span) => {
+  const text = span.innerText.replace(/,/g, '');
+
+  return Number(text);


You convert using Number(text) but do not check for NaN. Per checklist items #11 and #12 you must ensure each string can be converted to a number — validate with Number.isNaN() (or isFinite) and decide whether to skip invalid entries or handle them explicitly.

mateacademy-ai-mentor · 2026-02-13T20:31:02Z

src/scripts/main.js

+});
+
+const total = populations.reduce((sum, val) => sum + val, 0);
+const average = total / populations.length;


If populations is empty the computation total / populations.length will produce NaN or throw a logic error. Add a guard for an empty array (e.g. set average to 0 or avoid division) to satisfy correct average calculation (checklist item #3).

mateacademy-ai-mentor · 2026-02-13T20:31:02Z

src/scripts/main.js

+const total = populations.reduce((sum, val) => sum + val, 0);
+const average = total / populations.length;
+
+document.querySelector('.total-population').innerText = total.toLocaleString();


Writing directly to .total-population assumes the element exists. It’s safer to check the result of querySelector before setting innerText to avoid runtime errors. Also confirm you want toLocaleString() formatting here (this is correct for checklist items #7 and #8).

mateacademy-ai-mentor · 2026-02-13T20:31:02Z

src/scripts/main.js

+document.querySelector('.total-population').innerText = total.toLocaleString();
+
+document.querySelector('.average-population').innerText =
+  Math.round(average).toLocaleString();


Average is rounded and formatted which is fine, but compute/assign the rounded value to a variable first for clarity and easier testing. Also, ensure the target element exists before assigning innerText (see previous comment). This ties to checklist items #5, #7 and #8.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
_{[CODE: NCM]}

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

etojeDenys

good job, but don't forget to provide a demo link

solutions

ea12127

mateacademy-ai-mentor suggested changes Feb 13, 2026

View reviewed changes

OliverBars requested a review from mateacademy-ai-mentor February 14, 2026 18:13

mateacademy-ai-mentor reviewed Feb 14, 2026

View reviewed changes

etojeDenys approved these changes Feb 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

solutions#2182

solutions#2182
OliverBars wants to merge 1 commit intomate-academy:masterfrom
OliverBars:develop

OliverBars commented Feb 13, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

etojeDenys left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

OliverBars commented Feb 13, 2026

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Uh oh!

etojeDenys left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants