Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
You're on the right track with the overall structure, but the script currently isn't calculating the total and average correctly, resulting in NaN. This is because the Number() function cannot parse strings that contain commas as thousands separators, like '1,417,173,173'. To fix this, you need to remove the commas from the item.textContent string before converting it to a number. A string method like replace() would be perfect for this task. Once you make that small change, your calculations should work as expected.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| let total = 0; | ||
|
|
||
| for (const item of population) { | ||
| const number = Number(item.textContent); |
There was a problem hiding this comment.
The Number() function cannot parse a string that contains commas as thousands separators (e.g., '1,000'). This conversion will result in NaN. You'll need to remove the commas from item.textContent before converting the string to a number.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! You've successfully addressed the feedback from the previous review by removing the commas before converting the population strings to numbers. This has fixed the calculation bug perfectly. The script now correctly calculates and displays the total and average population, meeting all project requirements. I am approving your solution, great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.