Skip to content
Open

done #2471

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
36 changes: 34 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,40 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
// Se não houver callback --> lógica do Unicode
const compare =
compareFunction ||
((a, b) => {
const s1 = String(a);
const s2 = String(b);

if (s1 < s2) {
return -1;
}

if (s1 > s2) {
return 1;
}

return 0;
});

// Bubble Sort
for (let i = 0; i < this.length; i++) {
for (let j = 0; j < this.length - 1; j++) {
const resultado = compare(this[j], this[j + 1]);

if (resultado > 0) {
const temp = this[j];

this[j] = this[j + 1];
this[j + 1] = temp;
}
}
}
Comment on lines +27 to +38

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a correct implementation of Bubble Sort. For better performance, you could optimize the inner loop. With each pass of the outer loop, the largest remaining element moves to its final position, so the inner loop doesn't need to scan the entire array every time. Consider reducing the inner loop's boundary on each iteration, for example: for (let j = 0; j < this.length - 1 - i; j++).


return this;
};
}

Expand Down