-
Notifications
You must be signed in to change notification settings - Fork 2.6k
add task solution #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add task solution #2470
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,9 +4,41 @@ | |
| * Implement method Sort | ||
| */ | ||
| function applyCustomSort() { | ||
| [].__proto__.sort2 = function(compareFunction) { | ||
| // write code here | ||
| [].__proto__.sort2 = function (compareFunction) { | ||
| const defaultCompare = (a, b) => { | ||
| const A = String(a); | ||
| const B = String(b); | ||
|
|
||
| if (A < B) { | ||
| return -1; | ||
| } | ||
|
|
||
| if (A > B) { | ||
| return 1; | ||
| } | ||
|
|
||
| return 0; | ||
| }; | ||
|
|
||
| const cmp = | ||
| typeof compareFunction === 'function' ? compareFunction : defaultCompare; | ||
|
|
||
| for (let i = 1; i < this.length; i++) { | ||
| const key = this[i]; | ||
| let j = i - 1; | ||
|
|
||
| while (j >= 0 && cmp(this[j], key) > 0) { | ||
| this[j + 1] = this[j]; | ||
| j--; | ||
| } | ||
|
|
||
| this[j + 1] = key; | ||
| } | ||
|
|
||
| return this; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The task requires |
||
| }; | ||
| // eslint-disable-next-line no-extend-native | ||
| Array.prototype.sort = Array.prototype.sort2; | ||
| } | ||
|
|
||
| module.exports = applyCustomSort; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loop implements an insertion-sort-style algorithm (acceptable for this exercise). Note: for large arrays this is O(n²); consider mentioning or using a more efficient algorithm only if performance is a concern (not required for this task).