Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
36 changes: 34 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,41 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {
const defaultCompare = (a, b) => {
const A = String(a);
const B = String(b);

if (A < B) {
return -1;
}

if (A > B) {
return 1;
}

return 0;
};

const cmp =
typeof compareFunction === 'function' ? compareFunction : defaultCompare;

for (let i = 1; i < this.length; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loop implements an insertion-sort-style algorithm (acceptable for this exercise). Note: for large arrays this is O(n²); consider mentioning or using a more efficient algorithm only if performance is a concern (not required for this task).

const key = this[i];
let j = i - 1;

while (j >= 0 && cmp(this[j], key) > 0) {
this[j + 1] = this[j];
j--;
}

this[j + 1] = key;
}

return this;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires Array.prototype.sort to be implemented via the predefined sort2. You define sort2 but never assign it to Array.prototype.sort. After the sort2 definition add an assignment such as Array.prototype.sort = Array.prototype.sort2; so normal arr.sort() calls use your implementation.

};
// eslint-disable-next-line no-extend-native
Array.prototype.sort = Array.prototype.sort2;
}

module.exports = applyCustomSort;