Skip to content
Open

Develop #2467

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"license": "GPL-3.0",
"devDependencies": {
"@mate-academy/eslint-config": "latest",
"@mate-academy/scripts": "^1.8.6",
"@mate-academy/scripts": "^2.1.3",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^28.6.0",
"eslint-plugin-node": "^11.1.0",
Expand Down
35 changes: 33 additions & 2 deletions src/arrayMethodSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,39 @@
* Implement method Sort
*/
function applyCustomSort() {
[].__proto__.sort2 = function(compareFunction) {
// write code here
[].__proto__.sort2 = function (compareFunction) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the sort2 definition. Keeping sort2 inside applyCustomSort() is fine, but be aware of the initialization order described above — Array.prototype.sort must be wired to this implementation only once sort2 exists.

const input =
compareFunction ||
((a, b) => {
const A = String(a);
const B = String(b);

if (A === B) {
return 0;
}

return A > B ? 1 : -1;
});

for (let i = 0; i < this.length; i++) {
for (let j = 0; j < this.length - 1 - i; j++) {
const res = input(this[j], this[j + 1]);

if (res > 0) {
const buf = this[j];

this[j] = this[j + 1];
this[j + 1] = buf;
}
}
}

return this;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires that Array.prototype.sort be implemented using the predefined [].__proto__.sort2. This file only defines sort2 and never assigns or implements Array.prototype.sort. After the sort2 definition you should add an assignment such as:

Array.prototype.sort = function(compareFn) {
  return [].__proto__.sort2.call(this, compareFn);
};

This fixes the HIGH-severity missing requirement.

};

// eslint-disable-next-line no-extend-native
Array.prototype.sort = function (compareFunction) {
return [].__proto__.sort2.call(this, compareFunction);
};
}

Expand Down