-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Develop #2467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Develop #2467
Changes from all commits
9b6e7ba
caa947e
db21fba
5d3f83e
194b37a
2d1e708
ee8a77c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ master ] | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [20.x] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
| - name: Use Node.js ${{ matrix.node-version }} | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| - run: npm install | ||
| - run: npm test |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,39 @@ | |
| * Implement method Sort | ||
| */ | ||
| function applyCustomSort() { | ||
| [].__proto__.sort2 = function(compareFunction) { | ||
| // write code here | ||
| [].__proto__.sort2 = function (compareFunction) { | ||
| const input = | ||
| compareFunction || | ||
| ((a, b) => { | ||
| const A = String(a); | ||
| const B = String(b); | ||
|
|
||
| if (A === B) { | ||
| return 0; | ||
| } | ||
|
|
||
| return A > B ? 1 : -1; | ||
| }); | ||
|
|
||
| for (let i = 0; i < this.length; i++) { | ||
| for (let j = 0; j < this.length - 1 - i; j++) { | ||
| const res = input(this[j], this[j + 1]); | ||
|
|
||
| if (res > 0) { | ||
| const buf = this[j]; | ||
|
|
||
| this[j] = this[j + 1]; | ||
| this[j + 1] = buf; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return this; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The task requires that Array.prototype.sort = function(compareFn) {
return [].__proto__.sort2.call(this, compareFn);
};This fixes the HIGH-severity missing requirement. |
||
| }; | ||
|
|
||
| // eslint-disable-next-line no-extend-native | ||
| Array.prototype.sort = function (compareFunction) { | ||
| return [].__proto__.sort2.call(this, compareFunction); | ||
| }; | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the
sort2definition. Keepingsort2insideapplyCustomSort()is fine, but be aware of the initialization order described above —Array.prototype.sortmust be wired to this implementation only oncesort2exists.