Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the custom sort2 method! Your solution correctly handles both the default sorting behavior and sorting with a custom compareFunction, so I am approving your work. The logic is sound and meets all the core requirements.
One area for improvement is the code structure. The current implementation in src/arrayMethodSort.js has two separate blocks for sorting which are almost identical. To make your code more concise and maintainable, you could refactor this to use a single sorting loop and dynamically determine which comparison logic to use. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
src/arrayMethodSort.js
Outdated
| [].__proto__.sort2 = function(compareFunction) { | ||
| // write code here | ||
| [].__proto__.sort2 = function (compareFunction) { | ||
| if (typeof compareFunction !== 'function') { |
There was a problem hiding this comment.
This if statement creates two separate code paths that contain very similar sorting logic. This leads to code duplication. Consider refactoring to use a single sorting loop and dynamically determine which comparison logic to use inside it based on whether compareFunction was provided.
2 participants
No description provided.