Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job setting up the sort2 method on the array prototype and handling the custom compareFunction. Your implementation is on the right track!
However, this requires changes because the current logic for handling undefined values doesn't match the native Array.prototype.sort() behavior. The native method consistently moves all undefined elements to the end of the array. For example, [undefined, 1] should be sorted to [1, undefined], but your code leaves it as is.
Please adjust your comparison logic to ensure undefined values are always treated as greater than any other value, which will place them at the end of the sorted array. Once that's fixed, your implementation will be complete!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! Your solution is approved as you've successfully addressed the previous feedback. The logic for handling undefined values now correctly mimics the native sort behavior by moving them to the end of the array, and all task requirements are fully met. As a suggestion for future challenges, you might find it interesting to explore more performant sorting algorithms like Quick Sort or Merge Sort, but your current implementation is perfectly fine for this task. Great job!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.