Skip to content

add task solution#698

Open
OksanaSht wants to merge 3 commits intomate-academy:masterfrom
OksanaSht:develop
Open

add task solution#698
OksanaSht wants to merge 3 commits intomate-academy:masterfrom
OksanaSht:develop

Conversation

@OksanaSht
Copy link

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work you did!

To improve:

  1. When user clicks on Події div, wrong URL is opening:
Image

Probably, you forget to add anchor (#) inside href attribute?

  1. Pictures in this block:
Image Should be much wider (see [Figma mockup](https://www.figma.com/design/cRBCqE06cDrY3s4jX7h3iY/%D0%9D%D0%90%D0%9C%D0%A3--Edit-?node-id=0-1&p=f))
  1. Gallery block looks slightly broken:
Image
  1. Click on Send button should ONLY wipe entered data - no page-scrolls or reloadings allowed. See #15 of this instruction

  2. Would you mind to add scroll-behavior: smooth to page navigation? When I clicked on anchor link in Footer, it throwed me to chosen section immediately

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost done

  1. these should be links (google maps address, tel, and mailto)
Image
  1. you have a line that goes through the whole page
Image

there is a problem with this section. Try removing the inline pudding
Image

@OksanaSht OksanaSht requested a review from etojeDenys January 28, 2026 14:01
Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants