Museum landing page (EASY)#693
Open
maximtsyrulnyk wants to merge 2 commits intomate-academy:masterfrom
Open
Conversation
volodymyr-soltys97
suggested changes
Nov 27, 2025
volodymyr-soltys97
left a comment
volodymyr-soltys97
left a comment
There was a problem hiding this comment.
Hi, the demo link isn't working, you need to make a deploy and check the demo link after
| 12. Create a Pull Request (PR) from your branch `develop` to branch `master` of original repo. | ||
| 13. Replace `<your_account>` with your Github username in the | ||
| [DEMO LINK](https://<your_account>.github.io/Museum/). | ||
| [DEMO LINK](https://maximtsyrulnyk.github.io/Museum/). |
There was a problem hiding this comment.
Add this demo link to the PR description
2pasha
approved these changes
Nov 29, 2025
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
wow! 🤩 great animations! 🔥
- i recommend you to remove this text-shadows from entire page. IMHO it's little bit out of design system
- also i recommend you to convert you images to WebP format, because you have loaded your page with animations so you need to balance page performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done layout Museum landing page (EASY) task
DEMO LINK