Skip to content

Develop#689

Open
SerhiyDmytruk wants to merge 10 commits intomate-academy:masterfrom
SerhiyDmytruk:develop
Open

Develop#689
SerhiyDmytruk wants to merge 10 commits intomate-academy:masterfrom
SerhiyDmytruk:develop

Conversation

@SerhiyDmytruk
Copy link

No description provided.

@SerhiyDmytruk
Copy link
Author

Not yet ready

@SerhiyDmytruk SerhiyDmytruk reopened this Oct 14, 2025
@SerhiyDmytruk
Copy link
Author

SerhiyDmytruk commented Oct 14, 2025

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. there should be several different links, but now it's just one big address link
image
  1. remove base outline
image
  1. fix the menu. also, add a hover effect to the menu icon
image
  1. there should not be space
image
  1. page looks broken on phone and tablet versions
image image

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

To improve:

  1. You don't need to make hover sticky, please, fix it:
image
  1. Would you mind add some animation (transform, transition) on menu-open action?

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problems from the previous review were not fixed. make sure you deploy the changes

@SerhiyDmytruk
Copy link
Author

SerhiyDmytruk commented Oct 15, 2025

problems from the previous review were not fixed. make sure you deploy the changes

Yeap! 100% Sorry!

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants