Skip to content

Develop#682

Open
ArtemYakhno wants to merge 11 commits intomate-academy:masterfrom
ArtemYakhno:develop
Open

Develop#682
ArtemYakhno wants to merge 11 commits intomate-academy:masterfrom
ArtemYakhno:develop

Conversation

@ArtemYakhno
Copy link

DEMO https://artemyakhno.github.io/Museum/

X Don’t forget to add a title for the whole web page (it could be the name of your landing)
X A landing page is implemented strictly according to the design in Figma
X Links in the header and footer menus should lead to the corresponding blocks of the landing page
X The speed of animations is the same throughout the landing page (for example, increasing when hovering or moving blocks when scrolling)
X Placeholders in the forms suggest what to enter, and if there is a validation of the form, then it is clear in what format to enter the phone number
X Make sure everything looks neat on mobile and without horizontal scrolling
X Add favicon
X Add a smooth scroll for the whole page
X When you try to send the form there is no 405 error and the form is automatically cleared after submit and is scrolled to the top of the page or the page is reloaded
X The form shouldn’t submit empty
X The buttons "exhibitions" and "tickets" should lead to the block with current events
X The button "about us" should lead to the email digest
X Facebook and Instagram icons in the footer should be clickable and open the museum's social networks in a new tab
X Pictures in the gallery and exhibitions sections should increase on hover
X OPTIONAL: After everything is done, you can add a slider for viewing pictures in the gallery (for mobile version)

@vitalii-fedusov
Copy link

move phone numbers to the separate line and make them clickable tel link
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/a

image

@vitalii-fedusov
Copy link

footer should have max-width similiar as other blocks

image

Copy link

@vitalii-fedusov vitalii-fedusov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Lets fix small issues

Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greate job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants