Skip to content

help is needed#679

Open
Vall-Re wants to merge 5 commits intomate-academy:masterfrom
Vall-Re:develop
Open

help is needed#679
Vall-Re wants to merge 5 commits intomate-academy:masterfrom
Vall-Re:develop

Conversation

@Vall-Re
Copy link

@Vall-Re Vall-Re commented Sep 3, 2025

Доброго дня !
Я застрягла на тому як зробити правильний скрол для картинок галереї. Допоможіть!!
Також є питання як зробити так щоб коли меню активне затемнювався екран сторінки, тут ще немає ніяких ефектів. також зробіть будь-ласка загальну перевірку роботи і відгук що ще потрібно виправити.
Дякую!!

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should provide a demo link to your page
if you need help with the task, it is better to ask for help in the chat because it is difficult to communicate here

@Vall-Re
Copy link
Author

Vall-Re commented Sep 4, 2025

Good afternoon!
Thanks for the advice, I will use it in the future 🙂.
After thinking about this project all night, this morning I tried it again on my own and it seems to have worked out. Please check it out.

DEMO LINK.

Checklist for preparing a portfolio project
Tech review
[x] 1. Add favicon
[x] 2. Add a smooth scroll for the whole page (scroll-behavior: smooth;)
[x] 3. Logos in header and footer should be links to home page
[x] 4. Make sure when you click on logo there is no 404 error (Use href="#" in anchor tag)
[x] 5. Pictures in the gallery and exhibitions sections should increase on hover
[x] 6. All interactive elements(links, buttons, pictures, icons) should have a hover effect and cursor pointer. User must intuitively understand that he can interact with them
[x] 7. When a user clicks on Address Google Maps is opened in a new tab (Use target="_blank")
[x] 8. Make sure when you click on logo there is no 404 error (Use href="#" in anchor tag)
[x] 9. When you try to send the form there is no 405 error and the form is automatically cleared after submit and is scrolled to the top of the page or the page is reloaded
[x] 10. The form shouldn’t submit empty
[x] 11. After autocomplete the form, change the default styles. Read more about changing autocomplete styles
[x] 12. OPTIONAL: After everything is done, you can add a slider for viewing pictures in the gallery (for mobile version)
HR review
[x] 1. To make it clear to the recruiter what exactly this landing page is, it is better to give the whole web page the title
[x] 2. A landing page is implemented strictly according to the design in Figma
[x] 3. Links in the header and footer menus should lead to the corresponding blocks of the landing page
[x] 4. The speed of animations is the same throughout the landing page (for example, increasing when hovering or moving blocks when scrolling)
[x] 5. Placeholders in the forms suggest what to enter, and if there is a validation of the form, then it is clear in what format to enter the phone number
[x] 6. Make sure everything looks neat on mobile and without horizontal scrolling
[x] 7. The button "tickets" should lead to the block with current events
[x] 8. The button "about us" should lead to the email digest
[x] 9. All the social icons in the footer should be clickable and open the social networks in a new tab

@Vall-Re Vall-Re requested a review from etojeDenys September 4, 2025 18:08
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job.
to improve:

  1. adjust the line width to the text width
image
  1. center section content and increase title size
    your:
image

figma:
image

  1. fix the line width or place the text without wrapping it to another line
image

@Vall-Re
Copy link
Author

Vall-Re commented Sep 5, 2025

Hello!
Correction. Underlining links and the About Us section.

@Vall-Re Vall-Re requested a review from etojeDenys September 5, 2025 17:05
@Vall-Re
Copy link
Author

Vall-Re commented Sep 5, 2025

DEMO LINK.

@Vall-Re
Copy link
Author

Vall-Re commented Sep 5, 2025

image

.....I don't understand why the section about us is moving here... everything works fine for me via npm start

@Vall-Re
Copy link
Author

Vall-Re commented Sep 6, 2025

DEMO LINK.

trying to fix the section title

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great. Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants