Open
Conversation
etojeDenys
suggested changes
Aug 30, 2025
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
-
remove the page scrolling when the menu is open
-
page under the menu should look different
your:
figma:
-
add smooth scrolling to the page
-
it should be full-screen width
- remove base outline from input
vitalii-bondarenko-ua
suggested changes
Aug 31, 2025
vitalii-bondarenko-ua
left a comment
vitalii-bondarenko-ua
left a comment
There was a problem hiding this comment.
Good job.
Almost done.
Check font styles for some elements - they looks like mismatched to design.
For example:
etojeDenys
suggested changes
Aug 31, 2025
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
- make sure the background image takes up the full width of the screen
- at this width, you have a white line that runs through the entire page
- make sure the fonts are the same as the layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://Ivadriil.github.io/Museum/