Skip to content

ready #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Alexx-4 wants to merge 90 commits into
base: master
Choose a base branch
from
Open

ready #51

Alexx-4 wants to merge 90 commits into from

Conversation

@Alexx-4
Copy link

@Alexx-4 Alexx-4 commented Feb 26, 2022

No description provided.

Ale and others added 30 commits December 13, 2021 18:14
cmp files
a2285e2
Lexer
c212a41
cool grammar
f5ce791
ast
f204843
parser
84c7c4c
type_collector-type_builder
59abcc7
fixing some issues for type_check
06712f4
ast with tokens files-columns
c9f53ac
cool grammar lines-columns
08ec176
type checker
74b84d1
semantic fixed
80b120b
type builder fixed
0ae8c6d
fixing tokens in ast
f6607a7
working on type errors
cb800e7
main
d2f0420
changing lin-col in some tokens like tests
9373a10
execute project
f04e915
changing some semantic errors like tests
5fa3965
including fixed_tokens
d72b55d
fixed tokens in ast
12dbd4f
update errors tags and fixind variables in parents
7a13614
@Alexx-4
Update requirements.txt
deac2a5
updating all
ce0fabc
deleting unnecesary stuff
0de3bf1
update main
44538fb
instructions to run code
2ff9e92
updating code
30572b8
@Alexx-4
Update requirements.txt
63922dd
update lexer
3c6dc70
modifing lexer
71ebe1d
Ale and others added 26 commits February 20, 2022 12:29
working on cil visitor
182b96a
working on cil visitor
0d06518
modifying cil ast - begin with aritmectic
3aa7c4d
arith to cil
0eeaced
adding complNode to cil ast
8653e93
atomic nodes to cil
bf6beba
call node to cil
f8d1fe3
cool to cil
2d03d23
fixing some issues
c114563
modifying code to generate cil
f99bcd8
fixing main
b73b34c
@Darian10
Adding instruction to code_generation
a68e4be
files
0b0e40a
@Darian10
Adding mips
4d06080
@Alexx-4
Update Readme.md
08b6092
@Darian10
Fixing size ldata issue
a35cc67
@Darian10
Merge branch 'master' of https://github.com/BeginnerCompilers/cool-co…
ccbe961 
…mpiler-2021
@Darian10
Change abort msg like tests
1a04129
@Alexx-4
Update team.yml
03cb133
@Alexx-4
Delete cells.mips
492ddec
@Alexx-4
Delete primes.mips
2551b3a
rename to report
acbe11e
Merge branch 'master' of https://github.com/BeginnerCompilers/cool-co…
4fd5df2 
…mpiler-2021
report
66e4e4a
Merge branch 'master' of https://github.com/BeginnerCompilers/cool-co…
5789e8d 
…mpiler-2021
update report
fe8c4db
@jpconsuegra jpconsuegra self-assigned this Mar 10, 2022
@jpconsuegra
Copy link
Contributor

jpconsuegra commented Mar 10, 2022

Evaluación

  • Alejandro Campos
  • Darian Dominguez

Requisitos mínimos (3)

  • El proyecto pasa todos los tests
  • El informe existe y explica el uso del compilador y la arquitectura básica

Requisitos intermedios (4)

  • Se implementaron las fases de chequeo semántico de forma separada y utilizando patrones adecuados
  • La arquitectura del compilador está organizada de forma coherente y mantenible

Requisitos extra (5)

  • Se implementaron las fases de generación de código intermedio y código objeto con patrones adecuados
  • Se resolvieron los problemas de representación de objetos en memoria e invocación de métodos virtuales de forma eficiente
  • Se resolvieron los problemas de boxing/unboxing de forma eficiente
  • Se resuelve el case eficientemente

Comentarios

  • No encontré en el informe cómo se resuelven los métodos virtuales de forma que la invocación polimórfica sea O(1).
  • No encontré en el informe cómo resuelven los problemas de boxing/unboxing.
  • No encontré en el informe cómo resuelven el case.

Nota final

Evaluación Nota
Final 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jpconsuegra jpconsuegra

Labels

Aprobado Final Finalizado

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Alexx-4 @jpconsuegra @Darian10