Skip to content

Proyecto cmp #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mavaldivie wants to merge 88 commits into
base: master
Choose a base branch
from
Open

Proyecto cmp #13

mavaldivie wants to merge 88 commits into from

Conversation

@mavaldivie
Copy link

@mavaldivie mavaldivie commented Mar 1, 2021

No description provided.

mavaldivie and others added 30 commits February 24, 2021 02:20
@mavaldivie
"Lexer and Parser tests passed"
2b80744
@ClaudiaOM
Semantic Test Passed
555acb0
@mavaldivie
Informacion del equipo y cambios en la organizacion
7d87661
@mavaldivie
Agregada la dependencia de Ply
a5bcd94
@mavaldivie
Arreglados algunos errores en Semantic.py
268a87b
@mavaldivie
Arreglados algunos bugs e implementado el visitor de COOL para CIL
e5ffd5a
@mavaldivie
Arreglados algunos errores en CoolToCilVisitor.py
7f244d2
@mavaldivie
Implemented some of the methods in the CILtoMIPS visitor.
ce51935
@mavaldivie
Implemented most of the methods in CILtoMIPS visitor.
7115995
@mavaldivie
Finished CILtoMIPS visitor.
f88d04d
@ClaudiaOM
Line and column for CIL Classes
64dc8f9
@mavaldivie
Created MIPSAstFormatter file and class
9a90fc8
@mavaldivie
Merge remote-tracking branch 'origin/Claudia' into Marcos
57bffe6 
# Conflicts:
#	src/core/cil/BaseCOOLToCILVisitor.py
#	src/core/cil/CILAst.py
#	src/core/cil/COOLToCILVisitor.py
@mavaldivie
Fixed bugs
454abd4
@mavaldivie
Created MIPS formatter class
64c4ed0
@ClaudiaOM
Implemented MIPSAstFormatter
a684a7c
@ClaudiaOM
Implemented debug line and column for CilToMips
58e00e3
@mavaldivie
Fixed bug in Parser
b36bee8
@ClaudiaOM
Merge branches 'Claudia' and 'Marcos' of https://github.com/NinjaProg…
874ce41 
…rammers/cool-compiler-2021 into Claudia
@ClaudiaOM
Fixed bug with LabelNode in GotoNode.label
fca9c51
@ClaudiaOM
Fixed small bug in line and column in debug for Mips
bc2ef47
@ClaudiaOM
Fixed stype bug in FunctionCallNode in CooltoCilVisitor
ac9e333
@ClaudiaOM
Fixed depth bug in ClassDeclarationNode in TypeChecker
04352fa
@ClaudiaOM
Fixed depth bug in ClassDeclarationNode in TypeBuilder for IO,String,…
662821f 
…Bool,Int
@ClaudiaOM
Fixed self bug in FunctionCallNode
8ded685
@ClaudiaOM
Fixed bug
f77ba45
@ClaudiaOM
Print line and column Mips Formatter
250b2a4
@mavaldivie
Fixed bug with attribute declarations
54ffa32
@mavaldivie
Fixed bug with attribute declarations and herency
844877f
@mavaldivie
Merge remote-tracking branch 'origin/Claudia' into Marcos
0b89bb9 
# Conflicts:
#	src/core/mips/MIPSAstFormatter.py
mavaldivie and others added 20 commits February 21, 2022 00:22
@mavaldivie
Fixed read_string procedure to use the new malloc
3ff82d0
@mavaldivie
Fixed default variable declaration nodes
373dc6d
@mavaldivie
Fixed bug in concat procedure
2ca2d50
@mavaldivie
Removed TODOs
613e898
@ClaudiaOM
Begin Readme
e9e7ca4
@ClaudiaOM
Fix read end of file in read_str mips_code
79f2047
@mavaldivie
Merge branch 'Marcos' of /home/adrian/PycharmProjects/cool-compiler-2…
64d8640 
…021 with conflicts.
@mavaldivie
Merge remote-tracking branch 'origin/Claudia' into Marcos
e5f6d75
@mavaldivie
Fixed codegen test to its original state
42f70ad
@ClaudiaOM
Update Readme
f22da46
@mavaldivie
Added divide by zero runtime exception
1773168
@ClaudiaOM
Update Readme.
a51ca71 
Return complex and graph to original state
@ClaudiaOM
Merge remote-tracking branch 'origin/Marcos' into Claudia
44a8c17
@ClaudiaOM
Update Readme.
d7eb709
@ClaudiaOM
Update Readme an requirements.txt
27c1d0f
@ClaudiaOM
Added info to Readme file
61375f2
@ClaudiaOM
Refactored folders and file names
fbd42d9
@ClaudiaOM
Reformated code and files
bfc6d9d
@ClaudiaOM
Update Readme
3e2f2d8
@ClaudiaOM
Final Readme update.
a8499c4
@apiad
Copy link
Member

apiad commented Mar 8, 2022 •
edited
Loading

Evaluación

  • Claudia Olavarrieta Martínez
  • Marcos Adrián Valdivié Rodríguez
  • Adrián Hernández Pérez

Requisitos mínimos (3)

  • El proyecto pasa todos los tests
  • El informe existe y explica el uso del compilador y la arquitectura básica

Requisitos intermedios (4)

  • Se implementaron las fases de chequeo semántico de forma separada y utilizando patrones adecuados
  • La arquitectura del compilador está organizada de forma coherente y mantenible

Requisitos extra (5)

  • Se implementaron las fases de generación de código intermedio y código objeto con patrones adecuados
  • Se resolvieron los problemas de representación de objetos en memoria e invocación de métodos virtuales de forma eficiente
  • Se resolvieron los problemas de boxing/unboxing de forma eficiente

Comentarios

  • No encontré en el informe cómo se resuelven los métodos virtuales de forma que la invocación polimórfica sea O(1).
  • No encontré en el informe cómo resuelven los problemas de boxing/unboxing.

Nota final

Evaluación Nota
Final 4

@apiad apiad self-requested a review March 8, 2022 02:01
@jpconsuegra
Copy link
Contributor

jpconsuegra commented Mar 18, 2022

EXTRA

Se mantiene la nota.

Positivo:

  • Explicaron correctamente cómo se resuelven los métodos virtuales de forma que la invocación polimórfica sea O(1).

Negativo

  • Siempre tratan los tipos por valor como tipos por referencia.
  • Resuelven el case generando las opciones para todos los descendientes.

@jpconsuegra jpconsuegra self-assigned this Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apiad apiad Awaiting requested review from apiad

Assignees

@jpconsuegra jpconsuegra

Labels

Aprobado Final Finalizado

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mavaldivie @apiad @jpconsuegra @ClaudiaOM