Remove redundant [<RequireQualifiedAccess>]#18
Open
cotyar wants to merge 7 commits intomastoj:devfrom
Open
Conversation
Owner
|
@cotyar looks like you deleted the |
Collaborator
Author
|
Ops ... apologise
Shall we get the latest bootstrapper and rename it into paket.exe?
…On Sat, 17 Mar 2018, 21:05 Tomas Jansson, ***@***.***> wrote:
@cotyar <https://github.com/cotyar> looks like you deleted the
paket.bootstrapper.exe file. I use that in the build script to get the
latest paket.exe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvtbek0JRaKF_rdeDslyHsKWviK6Wwxks5tfXqAgaJpZM4SuEFu>
.
|
Owner
|
@cotyar why do you think we should do that? Can't we just have it named |
Owner
|
To be clear, I'm not saying I'm right or wrong here. Recommendation here states that it is the bootstrapper that should be added to source control: https://fsprojects.github.io/Paket/faq.html#What-files-should-I-commit |
Collaborator
Author
|
Happy with any of the options - it is totally your call.
It can be done because of: When paket.bootstrapper.exe is renamed to
paket.exe, the real paket.exe is downloaded to a temporary location and
executed with all arguments passed directly.
fsprojects.github.io/Paket/bootstrapper.html
…On Sat, 17 Mar 2018, 21:44 Tomas Jansson, ***@***.***> wrote:
To be clear, I'm not saying I'm right or wrong here. Recommendation here
states that it is the bootstrapper that should be added to source control:
https://fsprojects.github.io/Paket/faq.html#What-files-should-I-commit
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEvtbapitSUA9_SzNrzdvcvI2No5mH3aks5tfYPagaJpZM4SuEFu>
.
|
Owner
|
let's go for your suggestion then :) |
Changed benchmark to use TotalSeconds
Inlined everything
Concept of Effects added Some optimizations done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.