fix (#343) : Prevent page refresh when clicking "Fundamentals" button #344
Open
helloAmulya wants to merge 1 commit intomastering-js:masterfrom
Open
fix (#343) : Prevent page refresh when clicking "Fundamentals" button #344helloAmulya wants to merge 1 commit intomastering-js:masterfrom
helloAmulya wants to merge 1 commit intomastering-js:masterfrom
Conversation
…d of refreshing the page.
✅ Deploy Preview for masteringjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vkarpov15
reviewed
Nov 28, 2025
| const tag = t => ` | ||
| <span class="tag"> | ||
| <a href="/${t}">${t}</a> | ||
| <a href="/${p.url}">${t}</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in #343 where clicking the "Fundamentals" button caused a full page refresh instead of opening the detailed docs panel.
Root Cause:
The tag template used
{t}as the link text, which did not reference the correct variable and caused navigation instead of triggering the intended panel toggle.Screenshot:

Changes Made:
tagtemplate to use${t}inside the<a>tag, ensuring the correct text is rendered while preventing unintended page reloads.Working Example:
Screen.Recording.2025-08-16.at.3.53.58.AM.mov
Related Issue:
Closes #343