Handle Core Integrated/Special Systems & Mods correctly #2869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was sorta handling for this before, but it was being bricked by an incomplete IntegratedEquipment getter that always returned "weapon not found" for systems. I copied the handling for Special Equipment, which behaves correctly, and then just dummied out the weapon mod/pilot gear lines - those could easily be added, but I wanted to make it explicit that there is no current handling for either of those two things, so go figure. Integrated Systems additionally now display correctly, as well as special equipment of any kind (well, system/weapon/weapon mod). Abuses ternaries, so it's a bit ugly, but it's perfectly functional. It's this or duplicate a bunch of code, ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was sorta handling for this before, but it was being bricked by an incomplete IntegratedEquipment getter that always returned "weapon not found" for systems. I copied the handling for Special Equipment, which behaves correctly, and then just dummied out the weapon mod/pilot gear lines - those could easily be added, but I wanted to make it explicit that there is no current handling for either of those two things, so go figure.
Integrated Systems additionally now display correctly, as well as special equipment of any kind (well, system/weapon/weapon mod). Abuses ternaries, so it's a bit ugly, but it's perfectly functional. It's this or duplicate a bunch of code, ok?
To be clear - this has no effects on how integrated systems / special systems & mods are actually treated by compcon in any way other than on the frame page. They previously just didn't render, but functioned OK - and now they render & function.
(you're not supposed to have descriptions on integrated stuff, so ignore the encyc entry & SP on the mist feathers example. it was a tester screenshot. no SP/encyc entry looks fine, see the first screenshot)
(also ignore the long encyc entry on the special gun - compcon in general squishes weapons/systems that don't have long enough effects/descs, which is a ui "bug" (styling issue, more) unrelated to this)