assets/DP-39285-update-all-icons

[clairesunstudio]

Description

This PR:

• brings in all the new icons from the new DS icon library (based on this Figma changelog
  )
• consolidates and joins the Patternlab and React icon libraries into a single, shared and consistently-styled icon library
• adds auto optimization and cleanup scripts in the mayflower-assets library
• simplifies and making the icon styling consistent in the icon function for Patternlab - the icon() function in patternlab/openmass has been extended to take in name, width, height, classname
• certain icons, such as the chevron that's using CSS and one-off map-marker icon are not touched. We need to do some more work to those before swapping them out in OpenMass if we feel necessary.

Before:

After:

---

To Test:

Test in Mayflower

• Pull down this branch
• Run rush icons

This script does a few things:

1. It runs the prepIcons job in the assets package to strip fill and other attributes from the Figma exported svg icons, and run svgo lossless optimization on them
2. In Mayflower React: it builds each icon into a React component based on icon-template.js. Note that this step has been taken out of the start script, due to the number of icons slowing down the task
3. In Mayflower Patternlab: It copies SVG into the source directory and converts them to Twig to display them in patternlab. Note that Mayflower PHP icon function (packages/patternlab/styleguide/source/_twig-components/functions/icon.function.php) uses icons in the assets library directly

Test in Openmass:

• PR --> DP-39285 Update all icons openmass#3195
• Visual regression test --> https://output.circle-artifacts.com/output/job/01238f04-2350-4be6-9bdc-dc418213fc02/artifacts/0/backstop/report/index.html

[prisma-cloud-devsecops]

Prisma Cloud has found errors in this PR ⬇️

[prisma-cloud-devsecops]

  Information exposure through an error message
    File: icon-strip-fills.js | Checkov ID: CKV3_SAST_160

How To Fix

throw new Error('An unexpected error occurred');

Description

CWE: CWE-209: Generation of Error Message Containing Sensitive Information
OWASP: A04:2021-Insecure Design

This policy detects information exposure through an error message. If the code contains a pattern that matches either console.trace() or a try-catch block with a function containing one of the following methods: console.log, console.error, console.warn, alert, prompt, or confirm, and the catch block includes a variable $ERR or a variable that contains sensitive information such as message, stack, status, or name, then it is considered a vulnerability.

Vulnerable code example:

javascript
console.trace('Error message containing sensitive information');

The above code is vulnerable because it directly exposes sensitive information through the console.trace method.