-
Notifications
You must be signed in to change notification settings - Fork 25
DP-39213: Complete mayflower transition to css variables #2002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ethansev
wants to merge
35
commits into
develop
Choose a base branch
from
ethansev/DP-39213-Complete-mayflower-transition-to-css-variables
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DP-39213: Complete mayflower transition to css variables #2002
Ethansev
wants to merge
35
commits into
develop
from
ethansev/DP-39213-Complete-mayflower-transition-to-css-variables
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sition-to-css-variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the CSS variables transition started in DP-38077 by removing all SCSS color functions and introducing a modern CSS Grid system. It adds pre-calculated CSS variables for transparency and gradients to eliminate
rgba()usage, and provides new grid mixins to replace the deprecatedspan-columnssystem.Related Issue / Ticket
Steps to Test
rushx buildin the assets package to ensure SCSS compiles without errorsrushx stylelintto verify all SCSS follows coding standardsAdditional Notes:
Impacted Areas in Application
rgba()colors now use pre-calculated CSS variablesspan-columnscan now migrate to new ma-grid mixins@todo
rgbachanges due to the new defined colorsToday I learned...