Skip to content

Conversation

@Ethansev
Copy link
Contributor

Description

This PR completes the CSS variables transition started in DP-38077 by removing all SCSS color functions and introducing a modern CSS Grid system. It adds pre-calculated CSS variables for transparency and gradients to eliminate rgba() usage, and provides new grid mixins to replace the deprecated span-columns system.

Related Issue / Ticket

Steps to Test

  1. Run rushx build in the assets package to ensure SCSS compiles without errors
  2. Run rushx stylelint to verify all SCSS follows coding standards
  3. Run BackstopJS tests to confirm no visual regressions
  4. Verify grid layouts still work correctly
  5. Start react and patternlab apps to compare with production

Additional Notes:

  • All SCSS color functions (rgba, mix) have been replaced with CSS variables
  • New grid mixins provide better developer experience with validation and warnings
  • Fully backward compatible - existing layouts mostly unchanged, but there are some minor shifts occurring
  • Some production regressions have been automatically fixed due to the new grid system such as the Featured Topics section in the Organization Elected Official page

Impacted Areas in Application

  • All components using rgba() colors now use pre-calculated CSS variables
  • Components using span-columns can now migrate to new ma-grid mixins
  • This PR impacts the majority of the application

@todo

  • Monitor potential regressions from the rgba changes due to the new defined colors
  • Potential adjustments may be needed for responsive layouts due to the new grid system

Today I learned...

  • BackstopJS 4.5.0 uses an older Chromium that doesn't support modern CSS features like color-mix()
  • Some of our packages and documentation are outdated

notraiyan and others added 30 commits April 30, 2025 16:10
This reverts commit 58ee746.
This reverts commit 3aa1d7a.
…. Created new --mf-box-shadow css variable and updated mixins to handle dynamic variables.
@Ethansev Ethansev self-assigned this Jul 14, 2025
@Ethansev Ethansev requested a review from clairesunstudio July 14, 2025 16:08
@SkimAtMassGov SkimAtMassGov self-requested a review November 6, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants