Skip to content

test edit #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ygannett wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

test edit #1763

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1275f18
test edit
ygannett Apr 12, 2023
e0c39d4
test edit2
ygannett Apr 12, 2023
f1b1e0a
test edit 3
ygannett Apr 12, 2023
ca8ec10
test edit 4
ygannett Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/patternlab/styleguide/source/_patterns/02-molecules/main-nav.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
{% for nav in mainNav %}
{% set buttonId = 'button' ~ loop.index %}
{% set menuId = 'menu' ~ loop.index %}
<li role="none" class="ma__main-nav__item {{ nav.active ? 'is-active' : '' }} {{ nav.subNav ? 'has-subnav js-main-nav-toggle' : 'js-main-nav-top-link' }}" tabindex="-1">
<li role="{{ nav.subNav ? 'menuitem' : 'none' }}" class="ma__main-nav__item {{ nav.active ? 'is-active' : '' }} {{ nav.subNav ? 'has-subnav js-main-nav-toggle' : 'js-main-nav-top-link' }}" tabindex="-1">
{% if nav.subNav %}
<button type="button" role="menuitem" id="{{ buttonId }}" class="ma__main-nav__top-link" aria-haspopup="true" aria-expanded="false" tabindex="0">
<button type="button" id="{{ buttonId }}" class="ma__main-nav__top-link" aria-haspopup="true" aria-expanded="false" tabindex="0">
<span class="visually-hidden show-label">Show the sub topics of </span>
{{ nav.text }}
</button>
Expand All @@ -26,7 +26,7 @@
{% endif %}
<a role="menuitem" href="{{ nav.href }}" class="ma__main-nav__top-link {{ altClass }}" tabindex="0">{{ nav.text }}</a>
{% else %}
<button type="button" role="menuitem" id="{{ buttonId }}" class="ma__main-nav__top-link" tabindex="{{ loop.first? 0 : -1 }}">{{ nav.text }}</button>
<button type="button" id="{{ buttonId }}" class="ma__main-nav__top-link" tabindex="{{ loop.first? 0 : -1 }}">{{ nav.text }}</button>
{% endif %}
</li>
{% endfor %}
Expand Down