Initial Implementation of Organizations#995
Open
pahsivpahsiv wants to merge 4 commits intomassenergize:mainfrom
Open
Initial Implementation of Organizations#995pahsivpahsiv wants to merge 4 commits intomassenergize:mainfrom
pahsivpahsiv wants to merge 4 commits intomassenergize:mainfrom
Conversation
also fixed a typo
BradHN1
reviewed
May 13, 2024
|
|
||
|
|
||
| class Vendor(models.Model): | ||
| class Affiliate(models.Model): |
Contributor
There was a problem hiding this comment.
I suggest instead of Affiliate (which implies some affiliation, even its just a name) to call the base class Org
BradHN1
reviewed
May 13, 2024
BradHN1
reviewed
May 13, 2024
Fixed a redundant mention of service_area in filter_functions and added an allowed_users field in the Organization model class
Contributor
Has the inherittance uncertainty been resolved yet? |
archx3
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / Highlights
Organization functionality has been implemented analogous to Vendor class; also added an Affiliate class in models.py that Vendor and Organization both inherit from (could eventually replace shared functionality in other Vendor and Organization files - would need to test the database). Closes #976.
Details (Give details about what this PR accomplishes, include any screenshots etc)
Taken from https://docs.google.com/document/d/1eHafgpwCL_A7oL0DgtIANvQLgwk2vG10zllVe9gphBk/edit?usp=sharing
Testing Steps (Provide details on how your changes can be tested)
Need to test whether the Organization entry is implemented in the database (and whether inheriting from Affiliate class causes problems); need to add front-end functionality for adding Organizations in admin site
Requirements (place an
xin each[ ])Transparency (Project board)