Skip to content

Conversation

@coryodaniel
Copy link
Member

@coryodaniel coryodaniel commented Nov 9, 2025

Breaking this into a few smaller prs:

Package GET

Markdown report

mass pkg get api-prod-db

Full JSON object

mass pkg get api-prod-db -ojson

Package Configure STDIN support

mass pkg cfg --params -

name
}
}
artifacts {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a bit more than we actually need lol.

@coryodaniel coryodaniel marked this pull request as draft November 11, 2025 12:44
@coryodaniel
Copy link
Member Author

I'm going to break this into a few smaller PRs. No need to approve.

Comment on lines +232 to +240
if pkgParamsPath == "-" {
// Read from stdin
if err := json.NewDecoder(os.Stdin).Decode(&params); err != nil {
return fmt.Errorf("failed to decode JSON from stdin: %w", err)
}
} else {
if err := files.Read(pkgParamsPath, &params); err != nil {
return err
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to new pr

Suggested change
if pkgParamsPath == "-" {
// Read from stdin
if err := json.NewDecoder(os.Stdin).Decode(&params); err != nil {
return fmt.Errorf("failed to decode JSON from stdin: %w", err)
}
} else {
if err := files.Read(pkgParamsPath, &params); err != nil {
return err
}

@chrisghill chrisghill removed their request for review December 23, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants