Skip to content

Feat: show size in picker, better error messages #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maskudo merged 3 commits into from
Feb 25, 2025
Merged

Feat: show size in picker, better error messages #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ce881
refactor: remove duplicate
maskudo Feb 24, 2025
cb14752
feat: show size in picker
maskudo Feb 24, 2025
e0f7f53
feat: better error message on download fail
maskudo Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions lua/devdocs/docs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,13 +116,18 @@ end
---@param slug string Doc to be downloaded
---@param callback function Function called after download
M.DownloadDocs = function(slug, callback)
local downloadLink = 'https://documents.devdocs.io/' .. slug .. '/db.json'
local downloadLink = M.ConstructDownloadLink(slug)
vim.system({
'curl',
'-s',
'-sS',
downloadLink,
}, { text = false }, function(res)
assert(res.code == 0, 'Error downloading docs')
if res.code ~= 0 then
vim.schedule(function()
vim.notify('Error downloading doc for ' .. slug .. ': ' .. res.stderr)
end)
return
end
vim.system({
'jq',
'-c',
Expand Down
14 changes: 9 additions & 5 deletions lua/devdocs/picker.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,19 @@ M.ShowAllDocs = function()
local docs = D.GetDownloadableDocs()
local items = {}
for _, doc in ipairs(docs) do
table.insert(items, doc.slug)
local text = doc.slug
local size_in_mb = (math.ceil(doc.db_size / (1024 * 1024)))
text = text .. ' (' .. size_in_mb .. 'MB)'
table.insert(items, text)
end
---@diagnostic disable-next-line: redundant-parameter -- documentation error
vim.ui.select(items, { prompt = 'Select Doc to Download' }, function(selected)
if not selected then
vim.ui.select(items, { prompt = 'Select Doc to Download' }, function(_, index)
if not index then
return
end
vim.notify('Downloading docs for ' .. selected, vim.log.levels.INFO)
D.InstallDocs(selected)
local slug = docs[index].slug
vim.notify('Downloading docs for ' .. slug, vim.log.levels.INFO)
D.InstallDocs(slug)
end)
end

Expand Down