Add WebSocket Compression #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
cc @daveey |
'Cleanup properly on shutdown, and allow multiple reponse headers.'
Add changes from jssweb-socko repo
Upgrade dependencies
- bump Scala / Akka versions - fix some broken tests - remove static file serving, which we don't use anymore, and which was failing tests
maintenance on Socko
Switch Socko to use Pekko in v0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the WebSocketServerCompressionHandler so that socko will negotiate compression with clients that support it.
To do this I upgraded to the current stable branch of netty because compression support only came out in 4.1.0. I also add to switch to allowing WebSocket extensions in the WebSocketServerHandshakerFactory because compression uses those.