Skip to content

IOS-106 자잘한 HomeView UI 수정해요#75

Merged
dbqls200 merged 6 commits intodevelopfrom
design/IOS-106-replace-image
Jul 17, 2025
Merged

IOS-106 자잘한 HomeView UI 수정해요#75
dbqls200 merged 6 commits intodevelopfrom
design/IOS-106-replace-image

Conversation

@dbqls200
Copy link
Collaborator

@dbqls200 dbqls200 commented Jul 17, 2025

📌 배경

  • 홈 화면에 UI 수정사항이 생겼어요 (feat. 테토 박*혁 디자이너)

✅ 수정 내역

  • 미션 완료 Popup 내부에 사용되는 이미지가 교체됐어요.
    • (+) 이미지 사이즈, 좌우 padding 적용
  • 홈 화면 상단에 padding이 추가됐어요.

📢 리뷰 노트

  • 생략해용가리

📸 스크린샷

Before After
Before After

@linear
Copy link

linear bot commented Jul 17, 2025

@dbqls200 dbqls200 changed the title IOS-106 HomeView UI 수정 IOS-106 자잘한 HomeView UI 수정해요 Jul 17, 2025
Copy link
Member

@hope1053 hope1053 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 ! 코멘트 확인 한번만 빠르게 부탁드려여

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 다른데서 사용되는데 있나요? 없으면 지우는게 좋을 것 같아요!

Copy link
Collaborator Author

@dbqls200 dbqls200 Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헐! 지웠는데 분명 ????
빠르게 지우러 ..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.resizable()
.scaledToFit()
.frame(width: 161, height: 138)
.padding(.horizontal, 69.5)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 패딩값은 기기 해상도에 따라 달라질 것 같아요~ center align만 돼있으면 padding 안줘도 괜찮지 않을까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 그러네요
frame 지정해서 padding은 없어도 되겠군요!
IOS-106 del: 이미지 좌우 padding 제거 반영완 !

@dbqls200 dbqls200 requested a review from hope1053 July 17, 2025 05:58
Copy link
Member

@hope1053 hope1053 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@dbqls200 dbqls200 merged commit 302063f into develop Jul 17, 2025
@dbqls200 dbqls200 deleted the design/IOS-106-replace-image branch July 17, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants