Don't parse commented lines#9
Open
neauoire wants to merge 1 commit intomaryrosecook:masterfrom
neauoire:master
Open
Don't parse commented lines#9neauoire wants to merge 1 commit intomaryrosecook:masterfrom neauoire:master
neauoire wants to merge 1 commit intomaryrosecook:masterfrom
neauoire:master
Conversation
|
Just a note, this regular expression breaks if the commented line has leading whitespace. This slight modification fixes that:
|
Author
|
yes!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny PR so commented lines(lines starting with
;) will not be tokenized.I was going to go over this and convert all
var, intoconst, would that be something you'd like to merge as well?