Quad tree for collision detection#33
Open
maerch wants to merge 31 commits intomaryrosecook:masterfrom
Open
Conversation
maerch
commented
Dec 15, 2014
- Quad tree for efficient collision detection
- Shape class for extendable collision detection
…d extended by statistics about collision detection
… collision detection
…ize of quad tree)
README.md
Outdated
Owner
There was a problem hiding this comment.
Does the (for example) Coquette.Collider.Shape.Rectangle need to be instantiated? Can it not be preinstantiated inside Coquette and then just assigned inside an entity as before eg:
javascript
Collider.prototype = {
//...
RECTANGLE: new this.Shape.Rectangle(),
CIRCLE: new this.Shape.Circle()
}
var Ball = function() {
this.boundingBox = Coquette.Collider.RECTANGLE;
};
To support this, `this` inside the `isIntersecting()` functions would need to be used.
Owner
|
Thanks a lot for the PR! I've added a bunch of comments. Happy to discuss anytime. |
Author
|
Thanks for your suggestions. I have applied and pushed them. |
Owner
|
Thanks a lot for your edits. I'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.