Skip to content

Quad tree for collision detection#33

Open
maerch wants to merge 31 commits intomaryrosecook:masterfrom
maerch:master
Open

Quad tree for collision detection#33
maerch wants to merge 31 commits intomaryrosecook:masterfrom
maerch:master

Conversation

@maerch
Copy link

@maerch maerch commented Dec 15, 2014

  • Quad tree for efficient collision detection
  • Shape class for extendable collision detection

README.md Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the (for example) Coquette.Collider.Shape.Rectangle need to be instantiated? Can it not be preinstantiated inside Coquette and then just assigned inside an entity as before eg:

javascript

Collider.prototype = {
//...
RECTANGLE: new this.Shape.Rectangle(),
CIRCLE: new this.Shape.Circle()
}

var Ball = function() {
this.boundingBox = Coquette.Collider.RECTANGLE;
};


To support this, `this` inside the `isIntersecting()` functions would need to be used.

@maryrosecook
Copy link
Owner

Thanks a lot for the PR! I've added a bunch of comments. Happy to discuss anytime.

@maerch
Copy link
Author

maerch commented Dec 18, 2014

Thanks for your suggestions. I have applied and pushed them.

@maryrosecook
Copy link
Owner

Thanks a lot for your edits. I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants