Fix aligned malloc to ensure there is enough space to also store the original allocated pointer #82
Conversation
…original allocated pointer The current implementation for `Valigned_malloc` has a bug - it doesn't allocate enough bytes to also store the original `void` pointer `p0` that is needed later for the `free` operation to work. This change fixes that by adding `sizeof(void*)` to the amount of allocated memory.
|
@marton78 Can you please help review this PR? Thanks! |
|
@marton78 Thanks for reviewing the change! Do you mind adding me as a contributor to this repo so that I can push this change? |
|
I merged it, that was easier from mobile. Thanks! |
|
I'll comment - that was never an issue with original PFFFT. malloc is always at least 4 bytes aligned on 32-bit platforms and 8 bytes aligned on 64-bit platforms, usually alignment is 16 bytes. That means there's always at least sizeof(void*) bytes available after adding 64 bytes. |
|
Do you have an idea for a conditional compilation flag, @avaneev ? |
|
There was no conditions for the bug posted from what I can see. Probably custom memory management may yield a bug. It's indeed a bug, but not in the C standard framework where allocated structures have to be aligned. |
3 participants
The current implementation for
Valigned_mallochas a bug - it doesn't allocate enough bytes to also store the originalvoidpointerp0that is needed later for thefreeoperation to work. This change fixes that by addingsizeof(void*)to the amount of allocated memory.