Add void to signatures of argumentless functions #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marton78
approved these changes
Mar 19, 2025
Owner
|
Hey @thirtythreeforty, thanks a lot for your patch. I'd love to merge it but the CI is broken currently (see here) and I won't have time to fix it in the coming weeks. If you (or @hayguen?) find spare time to repair it, I'd be grateful. Then I'll be able to merge your PR. |
Contributor
Author
|
I'll take a look! |
Contributor
Author
|
#73 will fix the CI issues, and then I'll rebase this PR. |
This fixes pedantic compiler warnings of the form:
pffft.h:197:22: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
197 | int pffft_simd_size();
| ^
| void
thirtythreeforty
force-pushed
the
master
branch
from
957cbb1 to
07eea54
Compare
Contributor
Author
|
Rebased |
Owner
|
Thanks @thirtythreeforty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pedantic compiler warnings of the form: