Enhance benchmark run methods with setup and teardown#135
Closed
urcheon wants to merge 1 commit intomartinus:masterfrom
Closed
Enhance benchmark run methods with setup and teardown#135urcheon wants to merge 1 commit intomartinus:masterfrom
urcheon wants to merge 1 commit intomartinus:masterfrom
Conversation
Refactor benchmark run methods to include setup and teardown operations.
l0rinc
reviewed
Dec 19, 2025
| beginMeasure(); | ||
| op(); | ||
| endMeasure(); | ||
| teardown(); |
There was a problem hiding this comment.
can you please add a test which makes sure the setup and teardown costs aren't included in the measurements?
There was a problem hiding this comment.
Added it myself in #136 with a different implementation
This was referenced Jan 3, 2026
Author
|
Better implementation by l0rinc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor benchmark run methods to include setup and teardown operations.