Update wheel speeds #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wheel speeds scaling factor was originally estimated by Bugsy seem to have a 3% error across multiple users. Other platforms DBC file use the 0.057 scaling factor. Changing the Outback scaling factor to 0.057 provides a speed match between comma and vehicle speedometer on @wcleveland7 's 2016 Outback.
Owner
|
Car speedometer is usually off by a few kph/mph because of regulatory requirements, so openpilot is using average of wheel speeds to calculate actual speed. You could use high precision GPS to compare openpilot speed reading given the GPS reception is good. Please let me know if you get more precise speed reading by using current 0.0592 or global platform 0.057 scaling factor vs GPS reported speed. |
martinl
pushed a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wheel speeds scaling factor was originally estimated by Bugsy seem to have a 3% error across multiple users. Other platforms DBC file use the 0.057 scaling factor. Changing the Outback scaling factor to 0.057 provides a speed match between comma and vehicle speedometer on @wcleveland7 's 2016 Outback.