Skip to content

Add dolar tj and converter#2

Open
pabloferrari wants to merge 5 commits intomartincarrera:masterfrom
pabloferrari:add-dolar-tj-and-conversor
Open

Add dolar tj and converter#2
pabloferrari wants to merge 5 commits intomartincarrera:masterfrom
pabloferrari:add-dolar-tj-and-conversor

Conversation

@pabloferrari
Copy link
Copy Markdown

Added dollar TJ quote
image

Converter:

USD to ARS -> dolar :amount
ARS to USD -> dolar :amount --to-usd

image

@martincarrera
Copy link
Copy Markdown
Owner

Hey @pabloferrari, sorry I didn't see your PR before.

Can you extract the 1.65 to a constant at the top of the file, and verify if that number is still correct?

Thanks for taking the time to add this!

@martincarrera martincarrera self-requested a review October 27, 2022 19:29
@pabloferrari
Copy link
Copy Markdown
Author

Hey @martincarrera, I just updated the PR.

  • extracted CC conversion rate
  • changes in results and conversion

Screenshot 2022-12-28 at 12 23 14

Screenshot 2022-12-28 at 12 21 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants