Skip to content

489: feat!: Add a UnionSchemaBuilder #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-augment wants to merge 1 commit into
base: main
Choose a base branch
from
Open

489: feat!: Add a UnionSchemaBuilder #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions avro/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,8 +300,18 @@ pub enum Details {
#[error("Unions may not directly contain a union")]
GetNestedUnion,

#[error("Unions cannot contain duplicate types")]
GetUnionDuplicate,
#[error(
"Found two different maps while building Union: Schema::Map({0:?}), Schema::Map({1:?})"
)]
GetUnionDuplicateMap(Schema, Schema),

#[error(
"Found two different arrays while building Union: Schema::Array({0:?}), Schema::Array({1:?})"
)]
GetUnionDuplicateArray(Schema, Schema),

#[error("Unions cannot contain duplicate types, found at least two {0:?}")]
GetUnionDuplicate(SchemaKind),

#[error("Unions cannot contain more than one named schema with the same name: {0}")]
GetUnionDuplicateNamedSchemas(String),
Expand Down
2 changes: 1 addition & 1 deletion avro/src/schema/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ pub use crate::schema::{
RecordField, RecordFieldBuilder, RecordFieldOrder, RecordSchema, RecordSchemaBuilder,
},
resolve::ResolvedSchema,
union::UnionSchema,
union::{UnionSchema, UnionSchemaBuilder},
};
use crate::{
AvroResult,
Expand Down
2 changes: 1 addition & 1 deletion avro/src/schema/name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ use crate::{
///
/// More information about schema names can be found in the
/// [Avro specification](https://avro.apache.org/docs/++version++/specification/#names)
#[derive(Clone, Debug, Hash, PartialEq, Eq)]
#[derive(Clone, Debug, Hash, PartialEq, Eq, PartialOrd, Ord)]
pub struct Name {
pub name: String,
pub namespace: Namespace,
Expand Down
Loading