Skip to content

Replace poetry with uv #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smilesun merged 21 commits into from
Oct 16, 2025
Merged

Replace poetry with uv #52

smilesun merged 21 commits into from
Oct 16, 2025

Conversation

@smilesun
Copy link
Collaborator

@smilesun smilesun commented Oct 15, 2025

No description provided.

smilesun
smilesun commented Oct 16, 2025
View reviewed changes
pyproject.toml Outdated
"zipp==3.19.2 ; python_full_version == '3.9.*'",
]
[tool.setuptools.packages.find]
where = ["causalspyne"]
Copy link
Collaborator Author

@smilesun smilesun Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alex-Markham, I added this line since in the root directory of our repository we have directories called submodules and uv can not figure out which one is the package but in general, where should be "." instead of 1 directory futher. Do you have experience on this. I guess using "." might be the correct one so that the installed package can be imported but in our case we have submodules, so where="." is not possible.

Copy link
Collaborator

@Alex-Markham Alex-Markham Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the usual setup (according to most recent style guides) would be to put move the causalspyne/ dir to src/causalspyne, and then uv will find it automatically

@Alex-Markham
Copy link
Collaborator

Alex-Markham commented Oct 16, 2025

on my machine now, uv run pytest results in all passing tests, but that's for Python 3.12. My suggestion is that we only support >=3.12 and we adjust the github action tests accordingly

@smilesun
Copy link
Collaborator Author

smilesun commented Oct 16, 2025

i tried on my machine with simply changing the version from 0.1.5 to 0.1.6, and upload to pypi and it works!, so i will merge this PR

@smilesun
Copy link
Collaborator Author

smilesun commented Oct 16, 2025

changes of this PR is cloned to #53

@smilesun smilesun merged commit 924e1b6 into main Oct 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alex-Markham Alex-Markham Alex-Markham left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smilesun @Alex-Markham