Bug 621848 - Window loses focus when showing transient windows that do not take focus on map #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
type META_WINDOW_UTILITY or META_WINDOW_TOOLBAR. Closes #621848.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This bug has been initially created because of the Firefox bug (https://bugzilla.mozilla.org/show_bug.cgi?id=526941) which use the type _NET_WM_WINDOW_TYPE_UTILITY when opening a panel window that does not steal the focus (the noautofocus attribute of the panel is set to "true" in xul).
Reading the code of src/core/window.c and the comment http://git.gnome.org/browse/metacity/tree/src/core/window.c?id=b272c4ca7f3a784d011eea5c3fd348011f8558b3#n2136 it looks like this code path is mostly designed for transient window but actually window of type _NET_WM_WINDOW_TYPE_UTILITY or of type _NET_WM_WINDOW_TYPE_TOOLBAR are also taking this path which seems unappropriated.
The patch just tweak the "if" to ignore them