Add ability to get resource from base localization when it absent in current#117
Open
loginoleg wants to merge 1 commit intomarmelroy:masterfrom
Open
Add ability to get resource from base localization when it absent in current#117loginoleg wants to merge 1 commit intomarmelroy:masterfrom
loginoleg wants to merge 1 commit intomarmelroy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, there are Вase and French localizations with keys. In Вase we have English strings. French localization file missed "CANCEL_BUTTON" resource.
So, "CANCEL_BUTTON".localized() return key "CANCEL_BUTTON" when current localization is French. That's not so good.
With this fix, "CANCEL_BUTTON".localized() check to "CANCEL_BUTTON" resource in the Base table and return "Cancel".