Skip to content

Conversation

@compsci-philipu
Copy link

Submission of Homework by Philip Ulrich.

Submission of Homework by Philip Ulrich.
@felio92
Copy link
Contributor

felio92 commented Nov 14, 2018

Nice 1 m8

@compsci-philipu
Copy link
Author

uwotm8

Copy link
Member

@cwehmeyer cwehmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments:

  • please only commit empty notebooks
  • the first cell raises a syntax error (see below)
  • you can replace loops by using vectorized code (see below)
  • your use of white spaces and blank lines deviates a lot from the PEP8 recommendation
  • please rename your file as project-2-compsci-philipu within this PR
Syntax error in first cell
  File "cell_name", line 6
SyntaxError: from __future__ imports must occur at the beginning of the file
Nonvectorized code example
        oldpos=pos
        for j in range(1,len(pos)-1):
            new_pos=pos[j]+timestep*vel[j]+timestep**2*acceleration(j,pos)/2
            pos[j]=new_pos
            new_vel=vel[j]+timestep*(acceleration(j,oldpos)+acceleration(j,pos))
            vel[j]=new_vel

Copy link
Member

@cwehmeyer cwehmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues are still not addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants