Skip to content

LIN-22 Add cycling to tab/shift+tab views #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markmarkoh merged 1 commit into from
Dec 7, 2025
Merged

LIN-22 Add cycling to tab/shift+tab views #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/widgets/tab_widget.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ impl TabWidget {
let mut state = self.state.write().unwrap();
if state.selected_index < state.tabs.len() - 1 {
state.selected_index += 1;
} else {
state.selected_index = 0;
}
state.selected_index
}
Expand All @@ -96,6 +98,8 @@ impl TabWidget {
let mut state = self.state.write().unwrap();
if state.selected_index > 0 {
state.selected_index -= 1;
} else {
state.selected_index = state.tabs.len() - 1
}
state.selected_index
}
Expand Down Expand Up @@ -213,9 +217,7 @@ mod tests {
use ratatui::{Terminal, backend::TestBackend};

use crate::{
TabChangeEvent,
queries::custom_views_query,
widgets::{TabWidget, tab_widget::TabType},
queries::{custom_views_query, my_issues_query}, widgets::{tab_widget::TabType, TabWidget}, TabChangeEvent
};

use super::{Tab, TabWidgetState};
Expand Down Expand Up @@ -316,20 +318,15 @@ mod tests {
})
);

// but not passed b
// cycles to the first
let ev = app.handle_event(&create_key_event(KeyCode::Tab));
assert_eq!(
ev,
TabChangeEvent::FetchCustomViewIssues(custom_views_query::ViewFragment {
name: "slugb".into(),
slug_id: Some("slugb".into()),
color: Some("#fa0faf".to_string()),
icon: Some("Education".to_string()),
id: String::from("slugb")
})
TabChangeEvent::FetchMyIssues
);

// then back to a
// then back to a (twice to cycle back)
let _ = app.handle_event(&create_key_event(KeyCode::BackTab));
let ev = app.handle_event(&create_key_event(KeyCode::BackTab));
assert_eq!(
ev,
Expand Down