Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Node.js version requirement from 16.14 to 22.0 and modernizes the version enforcement mechanism by replacing a custom validation script with npm's built-in engine-strict feature.
Key changes:
- Removes custom Node.js version checking script in favor of npm's native engine enforcement
- Updates minimum Node.js version requirement to 22.0.0
- Bumps package version to 4.0.0 (major version due to breaking change in Node.js requirement)
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Removed preinstall/prestart/pretest hooks for version checking, updated engine requirement to Node 22+, bumped version to 4.0.0 |
| checkNodeVersion.js | Deleted custom Node.js version validation script |
| .npmrc | Added engine-strict configuration to enforce Node.js version requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
.npmrc
Outdated
| { | ||
| "engine-strict": true | ||
| } |
There was a problem hiding this comment.
The .npmrc file uses JSON format, but .npmrc files should use INI format (key=value pairs). The correct syntax should be engine-strict=true without braces or quotes.
| { | |
| "engine-strict": true | |
| } | |
| engine-strict=true |
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
Using .npmrc instead of custom script to cause an error on `npm install`.
92751bb to
92f2ab9
Compare
Using .npmrc instead of custom script to cause an error on
npm install.