MLE-24763 Upgrading from jshint to eslint#992
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project's linting infrastructure from jshint to eslint, introducing modern linting tooling while deferring whitespace/formatting enforcement to a future PR.
Key changes:
- Upgraded eslint from v8 to v9 with flat config format
- Replaced jshint with eslint in the gulp build pipeline
- Created comprehensive eslint configuration with many spacing rules temporarily disabled
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updated eslint to v9.37.0, added gulp-eslint-new, removed jshint and gulp-jshint dependencies |
| gulpfile.js | Replaced jshint linting task with eslint, updated file glob pattern to explicitly match .js files |
| eslint.config.js | Added new flat config with rules matching previous jshint settings, spacing/formatting rules disabled for now |
| .jshintrc | Removed legacy jshint configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
No linting fixes yet. Changing from the older jshint to the modern eslint. The eslint config doesn't enforce whitespace yet, will do that in a later PR.
6c1a18c to
14576cb
Compare
BillFarber
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linting fixes yet. Changing from the older jshint to the modern eslint. The eslint config doesn't enforce whitespace yet, will do that in a later PR.