MLE-24685 Fixing test-complete-app deploy#983
Merged
Conversation
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a Jenkins deployment issue by updating the ml-gradle plugin version from 4.7.0 to 6.0.1 in the test-complete-app, along with updating Gradle wrapper files to support the newer plugin version.
- Updated ml-gradle plugin from version 4.7.0 to 6.0.1 to resolve Jenkins resolution issues
- Upgraded Gradle wrapper from version 8.4 to 8.14.3 for compatibility
- Added documentation comment explaining the purpose of the build.gradle file
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test-complete-app/build.gradle | Updated ml-gradle plugin version and added explanatory comment |
| test-complete-app/gradle/wrapper/gradle-wrapper.properties | Upgraded Gradle distribution version and added timeout/validation settings |
| test-complete-app/gradlew | Updated Gradle wrapper script with modern POSIX-compliant implementation |
| test-complete-app/gradlew.bat | Updated Windows Gradle wrapper script with improved error handling and modern syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rjrudin
force-pushed
the
feature/gradle-fix
branch
from
a8b0850 to
b996f06
Compare
Jenkins is getting an issue resolving 4.7.0 ml-gradle, so shifting to 6.0.1 - which is fine to use here because we don't need ml-gradle for deploying any LSQT stuff.
rjrudin
force-pushed
the
feature/gradle-fix
branch
from
b996f06 to
202f9ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins is getting an issue resolving 4.7.0 ml-gradle, so shifting to 6.0.1 - which is fine to use here because we don't need ml-gradle for deploying any LSQT stuff.