MLE-24733 - revert test-complete-app#1008
Closed
BillFarber wants to merge 1 commit intomarklogic:developfrom
Closed
MLE-24733 - revert test-complete-app#1008BillFarber wants to merge 1 commit intomarklogic:developfrom
BillFarber wants to merge 1 commit intomarklogic:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the test-complete-app directory to its previous state by removing mlDeploy-related configuration, while preserving that functionality in a new test-complete-app-mlDeploy directory. This allows existing tests to continue passing while development work proceeds on the mlDeploy implementation.
Key Changes:
- Removed mlDeploy configuration properties and tasks from
test-complete-app - Created new
test-complete-app-mlDeploydirectory with the mlDeploy configuration - Added Gradle wrapper scripts and configuration files to the new directory
Reviewed Changes
Copilot reviewed 9 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-complete-app/gradle.properties | Removed mlDeploy-specific database and port configurations |
| test-complete-app/build.gradle | Removed curl tasks and mlDeploy task dependencies |
| test-complete-app-mlDeploy/src/main/ml-config/servers/rest-api-server.json | Added REST API server configuration with SSL settings |
| test-complete-app-mlDeploy/src/main/ml-config/security/certificate-templates/template-1.xml | Added SSL certificate template configuration |
| test-complete-app-mlDeploy/gradlew.bat | Added Gradle wrapper script for Windows |
| test-complete-app-mlDeploy/gradlew | Added Gradle wrapper script for Unix systems |
| test-complete-app-mlDeploy/gradle/wrapper/gradle-wrapper.properties | Added Gradle wrapper properties |
| test-complete-app-mlDeploy/gradle.properties | Added mlDeploy-specific configuration properties |
| test-complete-app-mlDeploy/build.gradle | Added build configuration with curl tasks and mlDeploy dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
BillFarber
force-pushed
the
revertTestCompleteApp
branch
from
b30e8fb to
e04c75f
Compare
rjrudin
previously approved these changes
Oct 21, 2025
Contributor
rjrudin
left a comment
rjrudin
left a comment
There was a problem hiding this comment.
One little tweak, then merge away once tests pass.
BillFarber
force-pushed
the
revertTestCompleteApp
branch
from
e04c75f to
816daeb
Compare
Moved the working version of the mlDeploy stuff to test-complete-app-mlDeploy
BillFarber
force-pushed
the
revertTestCompleteApp
branch
from
816daeb to
6e0319c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved the working version of the mlDeploy stuff to test-complete-app-mlDeploy
This will allow the old version of setup to run so that tests continue passing while work proceeds on mlDeploy.