Open
Conversation
…sm.s (and giving them space with a DS in the linker) causes it to trash code in qasm1.s. So it would really need to be positioned at the end of qasm2.s. but disk space is cheap enough I think we can skip being overly clever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qasm.s puts some variables in a DUM section at then end of the file (and gives them space with a DS in the linker). Unfortunately, this causes it to trash code in qasm1.s.
So it would really need to be positioned at the end of qasm2.s. but disk space is cheap enough nowadays I think we can skip being overly clever.