Skip to content

Conversation

@scivision
Copy link

@scivision scivision commented Mar 20, 2017

Fixes #7
concurrently updated import syntax so that I can load the test.

@markcwill
Copy link
Owner

Thanks for this @scivision! I'm in meetings all day yesterday and today, try to get this merged this week, but it looks pretty straightforward. Also, I need to add a CONTRIBUTING.md to this repo, and need to clarify licensing with NSHE (the state of Nevada).

Quickly: There is no python3 support for this module. This is not community developed code. This is running in production (where some of our internal db clients have official support only for python 2.7) and was thrown up on GitHub to share the code with other labs at their personal request. We own the copyright and are looking into releasing it under Apache 2.0

Prints should just be removed/replaced with stdout/stderr writes, and/or logging or test output. All of our modern stuff uses py.test, so these tests will be migrated. I'll put all this in a contrib notes file, but just wanted you to know why I make arbitrary demands. :)

@scivision
Copy link
Author

Hi Mark, I'm glad you've put this project on the web, so many publicly-funded projects are not. In the science world, publishing open code and data is rightfully becoming a requirement to become funded and published.

It's effectively cost-free (and future-proofing) to just have the code Python 2/3 compatible.

For printing, just print() is fine. If you want stderr you do print('my text',file=sys.stderr)

The logging module does give fine-grained control over verbosity and can include traceback to the file and line of code and time error occurred.

Finally, yes you want to point people to use the dev branch in some clear way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants