fix: convert JSON Schema draft-07 exclusive bounds to draft-04 format #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome DevTools MCP and other MCP servers use JSON Schema draft-07 where exclusiveMinimum/exclusiveMaximum are numeric values representing the actual bounds. However, kin-openapi (OpenAPI 3.0) expects these fields as booleans that modify the minimum/maximum values (draft-04 format). This fix recursively processes input schemas to convert: - exclusiveMinimum: N → minimum: N, exclusiveMinimum: true - exclusiveMaximum: N → maximum: N, exclusiveMaximum: true Handles nested schemas in properties, items, additionalProperties, and schema composition keywords (allOf, anyOf, oneOf, not). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds comprehensive tests for convertExclusiveBoundsToBoolean(): - Simple exclusiveMinimum/exclusiveMaximum conversion - Both bounds together - Already boolean values (draft-04 style, unchanged) - No exclusive bounds (unchanged) - Nested properties - Array items - allOf composition - additionalProperties - Real-world Chrome DevTools MCP schema example - Invalid JSON handling (returns unchanged) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Chrome DevTools MCP and other MCP servers use JSON Schema draft-07 where
exclusiveMinimum/exclusiveMaximumare numeric values. However,kin-openapi(used for OpenAPI 3.0 schema parsing) expects them as booleans (draft-04 format).This causes failures like:
Solution
Pre-process input schemas to convert numeric exclusive bounds to boolean format before unmarshaling:
exclusiveMinimum: 5→minimum: 5, exclusiveMinimum: trueexclusiveMaximum: 10→maximum: 10, exclusiveMaximum: trueThe conversion is recursive, handling nested schemas in:
propertiesitems(arrays)additionalPropertiesallOf,anyOf,oneOf,notTesting
Tested with Chrome DevTools MCP which uses draft-07 schemas extensively.
🤖 Generated with Claude Code