Skip to content

fix p5 import#8

Open
anpin wants to merge 2 commits intomark-gerarts:mainfrom
anpin:fix_import
Open

fix p5 import#8
anpin wants to merge 2 commits intomark-gerarts:mainfrom
anpin:fix_import

Conversation

@anpin
Copy link
Contributor

@anpin anpin commented Feb 25, 2025

closes #7

this PR changes import function for main P5 type

haven't tested this extensively, but this allowed my simple sketch to start

@mark-gerarts
Copy link
Owner

Thanks for looking into it! There is a "test suite" in the project that does a playwright page visit for every sketch in the reference site and checks if it still works (i.e. there are no console errors). Thing is, I'm struggling to get it running, my Fable compilation is giving me a hard time. I'll report back once I succeed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting a javascript console error when starting a minimalist project

2 participants