Add support for default value for radio button group in serialize data:#126
Open
stephanebachelier wants to merge 1 commit intomarionettejs:masterfrom
Open
Add support for default value for radio button group in serialize data:#126stephanebachelier wants to merge 1 commit intomarionettejs:masterfrom
stephanebachelier wants to merge 1 commit intomarionettejs:masterfrom
Conversation
* Default is set to null but it's easy to override. * Add value assigners to control value assignment to data
scott-w
reviewed
Dec 31, 2016
Member
scott-w
left a comment
scott-w
left a comment
There was a problem hiding this comment.
Hi @stephanebachelier thanks for submitting this. I appreciate it's been a while but if you can help me understand what's happening here I'll be more than happy to merge this and get it into a new release.
|
|
||
| // return value by default | ||
| ValueAssigners.registerDefault(function(value) { | ||
| return function(obj, key) { |
Member
There was a problem hiding this comment.
This feels like a complex implementation. Do you see developers adding their own custom ValueAssigners often?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in #102.
Previous PR in #106 then #112 on minor which is behind master. So this PR is made against master.
cc @rhubarbselleven