fix: address windows flakiness by reducing introspection calls #7678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dmadisetti
changed the title
mscolnick
previously approved these changes
Jan 5, 2026
akshayka
approved these changes
Jan 6, 2026
Contributor
akshayka
left a comment
akshayka
left a comment
There was a problem hiding this comment.
Approved if CI failure is unrelated
|
🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.18.5-dev155 |
Contributor
|
@dmadisetti those ci failures look related to the change in pixi maybe? |
Collaborator
Author
|
Ah dang. I though pixi lock lagged. I'm getting |
Contributor
|
it does not lag as far as i am aware, and yes seems like version mismatch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Pytest flakiness failures are related to timeout errors in windows. This reduces the number of frame calls needed (and hopefully) fixes the windows issues observed.